-
-
Notifications
You must be signed in to change notification settings - Fork 45
feat(add): Add minimum Node.js version warning if below 16. #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(add): Add minimum Node.js version warning if below 16. #625
Conversation
🦋 Changeset detectedLatest commit: babeec5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great start!
im not seeing any discussions for it, but couldn't we just add an |
I think I did some research last week and I think I remembered that npx and similar are not checking the node version for whatever reason. I haven't tested it though. |
Co-authored-by: Ben McCann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help! I have slightly adjusted the code to feel more like the rest of the codebase. But apart from that this was perfect!
I liked the style I did. But yes, it's ok to keep the repo style 🎉 |
Closes: #199